[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [kvm-unit-tests PATCH v7 01/11] run_tests: allow forcin
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [kvm-unit-tests PATCH v7 01/11] run_tests: allow forcing of acceleration mode |
Date: |
Mon, 28 Nov 2016 09:51:28 +0100 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Thu, Nov 24, 2016 at 04:10:23PM +0000, Alex Bennée wrote:
> While tests can be pegged to tcg it is useful to override this from time
> to time, especially when testing correctness on real systems.
> ---
> run_tests.sh | 8 ++++++--
> scripts/runtime.bash | 4 ++++
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/run_tests.sh b/run_tests.sh
> index 254129d..b88c36f 100755
> --- a/run_tests.sh
> +++ b/run_tests.sh
> @@ -13,9 +13,10 @@ function usage()
> {
> cat <<EOF
>
> -Usage: $0 [-g group] [-h] [-v]
> +Usage: $0 [-g group] [-a accel] [-h] [-v]
>
> -g: Only execute tests in the given group
> + -a: Force acceleration mode (tcg/kvm)
> -h: Output this help text
> -v: Enables verbose mode
>
> @@ -28,11 +29,14 @@ EOF
> RUNTIME_arch_run="./$TEST_DIR/run"
> source scripts/runtime.bash
>
> -while getopts "g:hv" opt; do
> +while getopts "g:a:hv" opt; do
> case $opt in
> g)
> only_group=$OPTARG
> ;;
> + a)
> + force_accel=$OPTARG
> + ;;
> h)
> usage
> exit
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index 11a40a9..578cf32 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -75,6 +75,10 @@ function run()
> return;
> fi
>
> + if [ -n "$force_accel" ]; then
> + accel=$force_accel
> + fi
> +
> if [ -n "$arch" ] && [ "$arch" != "$ARCH" ]; then
> echo "`SKIP` $1 ($arch only)"
> return 2
> --
> 2.10.1
We can already do 'ACCEL=tcg ./run_tests.sh' to force, for example, tcg.
Additionally, you can add any env you want to the config.mak after running
configure,
echo ACCEL=tcg >> config.mak
If you still prefer a cmdline parameter, then I'd suggest a boolean
instead, with the default being KVM. So the param would be '-tcg', or
something.
Thanks,
drew
- [Qemu-devel] [kvm-unit-tests PATCH v7 00/11] QEMU MTTCG Test cases, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 04/11] libcflat: add PRI(dux)32 format types, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 03/11] run_tests: allow passing of options to QEMU, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 02/11] run_tests: allow disabling of timeouts, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 09/11] arm/locking-tests: add comprehensive locking test, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 01/11] run_tests: allow forcing of acceleration mode, Alex Bennée, 2016/11/24
- Re: [Qemu-devel] [kvm-unit-tests PATCH v7 01/11] run_tests: allow forcing of acceleration mode,
Andrew Jones <=
- [Qemu-devel] [kvm-unit-tests PATCH v7 07/11] arm/tlbflush-code: Add TLB flush during code execution test, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 06/11] arm/Makefile.common: force -fno-pic, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 05/11] lib: add isaac prng library from CCAN, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 08/11] arm/tlbflush-data: Add TLB flush during data writes test, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 10/11] arm/barrier-litmus-tests: add simple mp and sal litmus tests, Alex Bennée, 2016/11/24
- [Qemu-devel] [kvm-unit-tests PATCH v7 11/11] arm/tcg-test: some basic TCG exercising tests, Alex Bennée, 2016/11/24
- Re: [Qemu-devel] [kvm-unit-tests PATCH v7 00/11] QEMU MTTCG Test cases, Andrew Jones, 2016/11/28