[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo |
|
Date: |
Mon, 28 Nov 2016 06:31:49 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/27/2016 11:53 AM, Laurent Vivier wrote:
>> tcg_gen_andi_i32(tmp, tmp, 31);
>> > mask = tcg_const_i32(0x7fffffffu);
>> > tcg_gen_shr_i32(mask, mask, tmp);
>> > + if (!TCGV_IS_UNUSED(tlen)) {
>> > + tcg_gen_mov_i32(tlen, tmp);
> We must add 1 here, otherwise the value stays between 0 and 31, not 1
> and 32:
>
> + tcg_gen_addi_i32(tlen, tmp, 1);
>
Yep, good catch.
r~