Re: [Qemu-devel] [libvirt] [RFC v2 00/20] qmp: Report bus information on 'query-machines'

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [libvirt] [RFC v2 00/20] qmp: Report bus information on 
'query-machines'
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
90c47fa pc: Initialize default bus lists
5e7855e pci: validate interfaces on base_class_init
ccf7181 q35: Hack to make root bus accept legacy PCI devices
e19e7f6 pci: Set device_type on bus classes
4c1b8d0 remove INTERFACE_LEGACY_PCI_DEVICE from PCIe-only devices
687122f eepro100: Add INTERFACE_LEGACY_PCI_DEVICE
87a772c Add INTERFACE_LEGACY_PCI_DEVICE to all PCI device subclasses
7d11921 edu: Move edu_info outside function
b64206d pci: Replace is_express with INTERFACE_PCIE_DEVICE
4117fca pci: INTERFACE_LEGACY_PCI_DEVICE and INTERFACE_PCIE_DEVICE interfaces
87f4a44 pvscsi: Set PCIDeviceClass::is_express=1
d77fcbc vmxnet3: Set PCIDeviceClass::is_express=1
be0dded virtio-pci: Set PCIDeviceClass::is_express=1
01c88b9 qmp: Add 'always-available-buses' field to 'query-machines'
3b00160 qdev: Add 'accepted-device-types' property to BusClass
7b98dda tests: Add rules to non-gtester qtest test cases
9dc8f87 qtest.py: Make 'binary' parameter optional
913752f qtest.py: make logging optional
a2621f3 qtest.py: Support QTEST_LOG environment variable
e765e8c qemu.py: Make logging optional

=== OUTPUT BEGIN ===
Checking PATCH 1/20: qemu.py: Make logging optional...
Checking PATCH 2/20: qtest.py: Support QTEST_LOG environment variable...
Checking PATCH 3/20: qtest.py: make logging optional...
WARNING: line over 80 characters
#26: FILE: scripts/qtest.py:87:
+                                               
socket_scm_helper=socket_scm_helper,

total: 0 errors, 1 warnings, 14 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/20: qtest.py: Make 'binary' parameter optional...
Checking PATCH 5/20: tests: Add rules to non-gtester qtest test cases...
Checking PATCH 6/20: qdev: Add 'accepted-device-types' property to BusClass...
Checking PATCH 7/20: qmp: Add 'always-available-buses' field to 
'query-machines'...
ERROR: line over 90 characters
#259: FILE: tests/qmp-machine-info.py:59:
+                dt = vm.qmp('qom-get', path=cp, 
property='accepted-device-types').get('return')

WARNING: line over 80 characters
#280: FILE: tests/qmp-machine-info.py:80:
+                btype = vm.qmp('qom-get', path=bus_id, 
property='type').get('return')

ERROR: line over 90 characters
#281: FILE: tests/qmp-machine-info.py:81:
+                self.assertEquals(btype, b['bus-type'], "bus-type mismatch for 
%s" % (bus_id))

ERROR: line over 90 characters
#282: FILE: tests/qmp-machine-info.py:82:
+                devtypes = vm.qmp('qom-get', path=bus_id, 
property='accepted-device-types').get('return')

ERROR: line over 90 characters
#283: FILE: tests/qmp-machine-info.py:83:
+                self.assertEquals(set(devtypes), 
set(b['accepted-device-types']), "device-type msimatch for %s" % (bus_id))

ERROR: line over 90 characters
#300: FILE: tests/qmp-machine-info.py:100:
+                self.fail("Unexpected inconsistency: some buses were found 
using qom-get, but not on the device tree: %r", found_buses)

WARNING: line over 80 characters
#315: FILE: tests/qmp-machine-info.py:115:
+            self.skipTest("machine %s on NODEFAULTS_BLACKLIST" % 
(machine['name']))

WARNING: line over 80 characters
#321: FILE: tests/qmp-machine-info.py:121:
+        """Dynamically add a testMachine_<arch>_<name>_<machine> method to the 
class"""

WARNING: line over 80 characters
#326: FILE: tests/qmp-machine-info.py:126:
+        method_name = 'test_%s_%s_%s' % (method_name, machine['arch'], 
machine_name)

ERROR: line over 90 characters
#339: FILE: tests/qmp-machine-info.py:139:
+        vm = qtest.QEMUQtestMachine(binary=binary, args=['-S', '-machine', 
'none'], logging=False)

WARNING: line over 80 characters
#358: FILE: tests/qmp-machine-info.py:158:
+        method_names = unittest.loader.getTestCaseNames(klass, 
prefix='machineTest')

total: 6 errors, 5 warnings, 335 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/20: virtio-pci: Set PCIDeviceClass::is_express=1...
Checking PATCH 9/20: vmxnet3: Set PCIDeviceClass::is_express=1...
Checking PATCH 10/20: pvscsi: Set PCIDeviceClass::is_express=1...
Checking PATCH 11/20: pci: INTERFACE_LEGACY_PCI_DEVICE and 
INTERFACE_PCIE_DEVICE interfaces...
Checking PATCH 12/20: pci: Replace is_express with INTERFACE_PCIE_DEVICE...
Checking PATCH 13/20: edu: Move edu_info outside function...
Checking PATCH 14/20: Add INTERFACE_LEGACY_PCI_DEVICE to all PCI device 
subclasses...
Checking PATCH 15/20: eepro100: Add INTERFACE_LEGACY_PCI_DEVICE...
Checking PATCH 16/20: remove INTERFACE_LEGACY_PCI_DEVICE from PCIe-only 
devices...
Checking PATCH 17/20: pci: Set device_type on bus classes...
Checking PATCH 18/20: q35: Hack to make root bus accept legacy PCI devices...
Checking PATCH 19/20: pci: validate interfaces on base_class_init...
Checking PATCH 20/20: pc: Initialize default bus lists...
WARNING: line over 80 characters
#42: FILE: hw/i386/pc_piix.c:442:
+    /* Sanity check to ensure we are reporting only legacy PCI devices as 
supported */

ERROR: line over 90 characters
#48: FILE: hw/i386/pc_piix.c:448:
+    machine_class_add_always_available_bus(m, "floppy-bus.0", "floppy-bus"); 
//FIXME: use macro

ERROR: do not use C99 // comments
#48: FILE: hw/i386/pc_piix.c:448:
+    machine_class_add_always_available_bus(m, "floppy-bus.0", "floppy-bus"); 
//FIXME: use macro

WARNING: line over 80 characters
#49: FILE: hw/i386/pc_piix.c:449:
+    machine_class_add_always_available_bus(m, "i2c", "i2c-bus"); //FIXME: use 
macro

ERROR: do not use C99 // comments
#49: FILE: hw/i386/pc_piix.c:449:
+    machine_class_add_always_available_bus(m, "i2c", "i2c-bus"); //FIXME: use 
macro

ERROR: do not use C99 // comments
#51: FILE: hw/i386/pc_piix.c:451:
+    machine_class_add_always_available_bus(m, "ide.0", "IDE");//FIXME: use 
macro

ERROR: do not use C99 // comments
#52: FILE: hw/i386/pc_piix.c:452:
+    machine_class_add_always_available_bus(m, "ide.1", "IDE");//FIXME: use 
macro

ERROR: line over 90 characters
#60: FILE: hw/i386/pc_piix.c:1101:
+    machine_class_add_always_available_bus(m, "floppy-bus.0", "floppy-bus"); 
//FIXME: use macro

ERROR: do not use C99 // comments
#60: FILE: hw/i386/pc_piix.c:1101:
+    machine_class_add_always_available_bus(m, "floppy-bus.0", "floppy-bus"); 
//FIXME: use macro

ERROR: do not use C99 // comments
#62: FILE: hw/i386/pc_piix.c:1103:
+    machine_class_add_always_available_bus(m, "ide.0", "IDE");//FIXME: use 
macro

ERROR: do not use C99 // comments
#63: FILE: hw/i386/pc_piix.c:1104:
+    machine_class_add_always_available_bus(m, "ide.1", "IDE");//FIXME: use 
macro

ERROR: line over 90 characters
#71: FILE: hw/i386/pc_piix.c:1124:
+    machine_class_add_always_available_bus(m, "floppy-bus.0", "floppy-bus"); 
//FIXME: use macro

ERROR: do not use C99 // comments
#71: FILE: hw/i386/pc_piix.c:1124:
+    machine_class_add_always_available_bus(m, "floppy-bus.0", "floppy-bus"); 
//FIXME: use macro

WARNING: line over 80 characters
#72: FILE: hw/i386/pc_piix.c:1125:
+    machine_class_add_always_available_bus(m, "i2c", "i2c-bus"); //FIXME: use 
macro

ERROR: do not use C99 // comments
#72: FILE: hw/i386/pc_piix.c:1125:
+    machine_class_add_always_available_bus(m, "i2c", "i2c-bus"); //FIXME: use 
macro

ERROR: do not use C99 // comments
#75: FILE: hw/i386/pc_piix.c:1128:
+    machine_class_add_always_available_bus(m, "ide.0", "IDE");//FIXME: use 
macro

ERROR: do not use C99 // comments
#76: FILE: hw/i386/pc_piix.c:1129:
+    machine_class_add_always_available_bus(m, "ide.1", "IDE");//FIXME: use 
macro

WARNING: line over 80 characters
#108: FILE: hw/i386/pc_q35.c:308:
+    machine_class_add_always_available_bus(m, "i2c", "i2c-bus"); //FIXME: use 
macro

ERROR: do not use C99 // comments
#108: FILE: hw/i386/pc_q35.c:308:
+    machine_class_add_always_available_bus(m, "i2c", "i2c-bus"); //FIXME: use 
macro

ERROR: do not use C99 // comments
#110: FILE: hw/i386/pc_q35.c:310:
+    machine_class_add_always_available_bus(m, "ide.0", "IDE");//FIXME: use 
macro

ERROR: do not use C99 // comments
#111: FILE: hw/i386/pc_q35.c:311:
+    machine_class_add_always_available_bus(m, "ide.1", "IDE");//FIXME: use 
macro

ERROR: do not use C99 // comments
#112: FILE: hw/i386/pc_q35.c:312:
+    machine_class_add_always_available_bus(m, "ide.2", "IDE");//FIXME: use 
macro

ERROR: do not use C99 // comments
#113: FILE: hw/i386/pc_q35.c:313:
+    machine_class_add_always_available_bus(m, "ide.3", "IDE");//FIXME: use 
macro

ERROR: do not use C99 // comments
#114: FILE: hw/i386/pc_q35.c:314:
+    machine_class_add_always_available_bus(m, "ide.4", "IDE");//FIXME: use 
macro

ERROR: do not use C99 // comments
#115: FILE: hw/i386/pc_q35.c:315:
+    machine_class_add_always_available_bus(m, "ide.5", "IDE");//FIXME: use 
macro

total: 21 errors, 4 warnings, 88 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden