Re: [Qemu-devel] [PATCH] include: Add roundup_pow_of_two helper function

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] include: Add roundup_pow_of_two helper function
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
61b93c6 include: Add roundup_pow_of_two helper function

=== OUTPUT BEGIN ===
Checking PATCH 1/1: include: Add roundup_pow_of_two helper function...
ERROR: code indent should never use tabs
#51: FILE: include/qemu/osdep.h:199:
+^Ix |= (x >> 1);$

ERROR: code indent should never use tabs
#52: FILE: include/qemu/osdep.h:200:
+^Ix |= (x >> 2);$

ERROR: code indent should never use tabs
#53: FILE: include/qemu/osdep.h:201:
+^Ix |= (x >> 4);$

ERROR: code indent should never use tabs
#54: FILE: include/qemu/osdep.h:202:
+^Ix |= (x >> 8);$

ERROR: code indent should never use tabs
#55: FILE: include/qemu/osdep.h:203:
+^Ix |= (x >> 16);$

ERROR: code indent should never use tabs
#56: FILE: include/qemu/osdep.h:204:
+^Ireturn x + 1;$

total: 6 errors, 0 warnings, 40 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden