Re: [Qemu-devel] [PATCH 0/2] Add Atmel I2C TPM AT97SC3204T emulated device

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/2] Add Atmel I2C TPM AT97SC3204T emulated device
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
46ef6f2 tpm: Add TPM I2C Atmel frontend
24c07aa i2c: Add flag to NACK I2C transfers when busy

=== OUTPUT BEGIN ===
Checking PATCH 1/2: i2c: Add flag to NACK I2C transfers when busy...
Checking PATCH 2/2: tpm: Add TPM I2C Atmel frontend...
WARNING: line over 80 characters
#127: FILE: hw/tpm/tpm_i2c_atmel.c:83:
+static void tpm_i2c_atmel_show_buffer(const TPMSizedBuffer *sb, const char 
*string)

ERROR: spaces required around that '-' (ctx:VxV)
#235: FILE: hw/tpm/tpm_i2c_atmel.c:191:
+                ret, tis->loc[0].r_offset-1);
                                          ^

WARNING: line over 80 characters
#301: FILE: hw/tpm/tpm_i2c_atmel.c:257:
+        error_setg(errp, "tpm_i2c_atmel: backend driver with id %s could not 
be "

WARNING: line over 80 characters
#309: FILE: hw/tpm/tpm_i2c_atmel.c:265:
+        error_setg(errp, "tpm_i2c_atmel: backend driver with id %s could not 
be "

WARNING: line over 80 characters
#315: FILE: hw/tpm/tpm_i2c_atmel.c:271:
+        error_setg(errp, "tpm_i2c_atmel: IRQ %d for TPM TIS is outside valid 
range "

total: 1 errors, 4 warnings, 372 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden