qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v10 00/10] vfio-pci: pass the aer error to guest


From: no-reply
Subject: Re: [Qemu-devel] [PATCH v10 00/10] vfio-pci: pass the aer error to guest
Date: Tue, 29 Nov 2016 05:33:00 -0800 (PST)

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v10 00/10] vfio-pci: pass the aer error to guest
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0bffb84 vfio: add 'aer' property to expose aercap
9b06ac3 vfio-pci: pass the aer error to guest
4e9a3ad vfio: check aer functionality for hotplugged device
666206a pci: introduce function validation check during hotplug
344ab2b vfio: add check host bus reset is support or not
3b4bb2b vfio: refine function vfio_pci_host_match
9527ac2 vfio: new function to init aer cap for vfio device
9a0ae86 pcie_aer: support configurable AER capa version
646d5a3 vfio: squeeze out vfio_pci_do_hot_reset to support bus reset
45d8932 vfio: extract vfio_get_hot_reset_info as a single function

=== OUTPUT BEGIN ===
Checking PATCH 1/10: vfio: extract vfio_get_hot_reset_info as a single 
function...
Checking PATCH 2/10: vfio: squeeze out vfio_pci_do_hot_reset to support bus 
reset...
Checking PATCH 3/10: pcie_aer: support configurable AER capa version...
Checking PATCH 4/10: vfio: new function to init aer cap for vfio device...
Checking PATCH 5/10: vfio: refine function vfio_pci_host_match...
Checking PATCH 6/10: vfio: add check host bus reset is support or not...
Checking PATCH 7/10: pci: introduce function validation check during hotplug...
Checking PATCH 8/10: vfio: check aer functionality for hotplugged device...
Checking PATCH 9/10: vfio-pci: pass the aer error to guest...
WARNING: line over 80 characters
#36: FILE: hw/vfio/pci.c:2728:
+    /* Read the uncorrectable error status from vfio-pci driver via the 
eventfd */

ERROR: trailing whitespace
#67: FILE: hw/vfio/pci.c:2758:
+ $

total: 1 errors, 1 warnings, 63 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/10: vfio: add 'aer' property to expose aercap...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]