[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/9] quorum: Inline quorum_aio_cb()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/9] quorum: Inline quorum_aio_cb() |
Date: |
Tue, 29 Nov 2016 14:38:00 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 29.11.2016 um 11:06 hat Alberto Garcia geschrieben:
> On Tue 29 Nov 2016 10:39:12 AM CET, Paolo Bonzini wrote:
> > On 22/11/2016 13:24, Kevin Wolf wrote:
> >> +
> >> + assert(rewrite == !!acb->rewrite_count);
> >
> > I think this might actually trigger if none of the rewrite coroutines
> > yields.
>
> I think you're right. Good catch, Paolo. Actually in the new code
> 'rewrite' doesn't have any purpose; it was previously needed to decide
> whether to call quorum_aio_finalize() at the end of quorum_aio_cb(), but
> this is not necessary now.
I'll remove the assertion and make quorum_vote() a void function.
Kevin
- [Qemu-devel] [PATCH v2 0/9] quorum: Implement .bdrv_co_preadv/pwritev(), Kevin Wolf, 2016/11/22
- [Qemu-devel] [PATCH v2 1/9] coroutine: Introduce qemu_coroutine_enter_if_inactive(), Kevin Wolf, 2016/11/22
- [Qemu-devel] [PATCH v2 2/9] quorum: Remove s from quorum_aio_get() arguments, Kevin Wolf, 2016/11/22
- [Qemu-devel] [PATCH v2 4/9] quorum: Do cleanup in caller coroutine, Kevin Wolf, 2016/11/22
- [Qemu-devel] [PATCH v2 3/9] quorum: Implement .bdrv_co_readv/writev, Kevin Wolf, 2016/11/22
- [Qemu-devel] [PATCH v2 6/9] quorum: Avoid bdrv_aio_writev() for rewrites, Kevin Wolf, 2016/11/22
- [Qemu-devel] [PATCH v2 5/9] quorum: Inline quorum_aio_cb(), Kevin Wolf, 2016/11/22
- [Qemu-devel] [PATCH v2 8/9] quorum: Inline quorum_fifo_aio_cb(), Kevin Wolf, 2016/11/22
- [Qemu-devel] [PATCH v2 9/9] quorum: Clean up quorum_aio_get(), Kevin Wolf, 2016/11/22
- [Qemu-devel] [PATCH v2 7/9] quorum: Implement .bdrv_co_preadv/pwritev(), Kevin Wolf, 2016/11/22