[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches |
Date: |
Wed, 30 Nov 2016 13:03:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 |
On 11/30/16 11:55, Gerd Hoffmann wrote:
> On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote:
>> Recent git releases support the diff.orderFile permanent setting.
>
> Cool.
>
>> configure
>> *Makefile*
>> *.json
>> *.txt
>> *.h
>> *.c
>
> I'd put *.txt to the head so doc updates come first.
Good idea, yes.
> Otherwise the order looks good to me.
>
> Want sent a patch?
What file for? :)
I've considered modifying
<http://wiki.qemu.org/Contribute/SubmitAPatch>, but that article is
humongous already.
Nonetheless, section "Make code motion patches easy to review" mentions
some diff.* settings, so I guess a new section after it ("Format
declarative and abstract changes near the top") would be appropriate, if
there's no disagreement.
> Can this be automatically enabled per repo, like .gitignore, so it works
> without everybody tweaking its local git config?
Not to my understanding.
Thanks!
Laszlo
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches, Michael S. Tsirkin, 2016/11/30
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches, Stefan Hajnoczi, 2016/11/30
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches, Eric Blake, 2016/11/30