[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches |
Date: |
Wed, 30 Nov 2016 20:27:03 +0800 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, 11/30 13:03, Laszlo Ersek wrote:
> On 11/30/16 11:55, Gerd Hoffmann wrote:
> > On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote:
> >> Recent git releases support the diff.orderFile permanent setting.
> >
> > Cool.
> >
> >> configure
> >> *Makefile*
> >> *.json
> >> *.txt
> >> *.h
> >> *.c
> >
> > I'd put *.txt to the head so doc updates come first.
>
> Good idea, yes.
>
> > Otherwise the order looks good to me.
> >
> > Want sent a patch?
>
> What file for? :)
This is a nice feature, thanks!
Does it make sense to have a .gitpublish file (for Stefan's git-publish script)
in QEMU.git? That way we can add a new profile option to git-publish and let it
build the command line accordingly. This is going to be helpful for those who
already use git-publish.
>
> I've considered modifying
> <http://wiki.qemu.org/Contribute/SubmitAPatch>, but that article is
> humongous already.
And this sounds good too.
Fam
>
> Nonetheless, section "Make code motion patches easy to review" mentions
> some diff.* settings, so I guess a new section after it ("Format
> declarative and abstract changes near the top") would be appropriate, if
> there's no disagreement.
>
> > Can this be automatically enabled per repo, like .gitignore, so it works
> > without everybody tweaking its local git config?
>
> Not to my understanding.
>
> Thanks!
> Laszlo
>
>
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches, Michael S. Tsirkin, 2016/11/30
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches, Stefan Hajnoczi, 2016/11/30
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches, Eric Blake, 2016/11/30