[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] a suggestion to place *.c hunks last in patches |
Date: |
Wed, 30 Nov 2016 15:35:09 +0000 |
On Wed, Nov 30, 2016 at 10:08 AM, Laszlo Ersek <address@hidden> wrote:
> Recent git releases support the diff.orderFile permanent setting. (In
> older releases, the -O option had to be specified on the command line,
> or in aliases, for the same effect, which was quite inconvenient.) From
> git-diff(1):
>
> -O<orderfile>
> Output the patch in the order specified in the <orderfile>,
> which has one shell glob pattern per line. This overrides
> the diff.orderFile configuration variable (see git-
> config(1)). To cancel diff.orderFile, use -O/dev/null.
>
> In my experience, an order file such as:
>
> configure
> *Makefile*
> *.json
> *.txt
> *.h
> *.c
>
> that is, a priority order that goes from
> descriptive/declarative/abstract to imperative/specific works wonders
> for reviewing.
Thanks, you are a gentleman and a scholar!
I've set it in my global git config.
Stefan