[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/2] Qemu: gdbstub: fix vCont
From: |
Claudio Imbrenda |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/2] Qemu: gdbstub: fix vCont |
Date: |
Wed, 30 Nov 2016 16:37:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Hi Paolo, I was wondering if you had seen this new version of the vCont
patchset, which I sent around last month -- is there any more work to do
or things to fix? or is it going to be upstreamed after 2.8?
(btw I just rebased it on 2.8.0-rc2 and it applied cleanly)
please don't keep me in suspense :)
thanks!
Claudio
On 28/10/16 19:15, Claudio Imbrenda wrote:
> This small patchset fixes the incorrect behaviour of the vCont command
> in the gdb stub.
>
> The first patch, as suggested be Paolo, refactors some code. The most
> visible change is that it moves vm_start to cpus.c
>
> The second one fixes the incorrect behaviour of the vCont command.
> Previously, continuing or stepping a single thread (CPU) caused all
> other CPUs to be started too, whereas the GDB specification clearly
> states that without a default action all threads not explicitly
> mentioned in the command should stay stopped.
>
> So if the Qemu gdbstub receives a vCont;c:1 packet, no other CPU
> should be restarted except the first, and when a vCont;s:1 is
> received, the first CPU should be stepped without restarting the others.
> With this patchset Qemu now behaves as expected.
>
> See here for reference material about the packets:
> https://sourceware.org/gdb/current/onlinedocs/gdb/Packets.html
> https://sourceware.org/gdb/onlinedocs/gdb/Packets.html
>
> v2 -> v3
> * removed resume_some_vcpus
> * cleared up the code and simplified the implementation in light of the
> clarification in the specification of the vCont packet
>
> Claudio Imbrenda (2):
> move vm_start to cpus.c
> gdbstub: Fix vCont behaviour
>
> cpus.c | 44 ++++++++++-
> gdbstub.c | 189
> ++++++++++++++++++++++++++++++++++-----------
> hw/i386/kvmvapic.c | 2 +
> include/sysemu/cpus.h | 1 +
> include/sysemu/sysemu.h | 2 +
> target-s390x/misc_helper.c | 2 +
> vl.c | 32 +-------
> 7 files changed, 195 insertions(+), 77 deletions(-)
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 0/2] Qemu: gdbstub: fix vCont,
Claudio Imbrenda <=