Re: [Qemu-devel] [PATCH 3/3] Add a new qmp command to do checkpoint, get replication error

[Zhang Chen]

On 12/01/2016 10:55 PM, Eric Blake wrote:
> On 12/01/2016 12:06 AM, Zhang Chen wrote:
> > We can call this qmp command to do checkpoint outside of qemu.
> > Like Xen colo need this function.
> >
> > Signed-off-by: Zhang Chen <address@hidden>
> > Signed-off-by: Wen Congyang <address@hidden>
> > ---
> >   docs/qmp-commands.txt | 24 ++++++++++++++++++++++++
> > +++ b/qapi-schema.json
> > @@ -4694,6 +4694,28 @@
> >     'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
> >   
> >   ##
> > +# @xen-get-replication-error
> > +#
> > +# Get replicatin error that occurs when the vm is running
> s/replicatin/replication/

OK.

> > +#
> > +# Returns: nothing
> > +#
> > +# Since: 2.8
> You've missed 2.8.

I will fix this in next version.


> > +##
> > +{ 'command': 'xen-get-replication-error' }
> > +
> > +##
> > +# @xen-do-checkpoint
> > +#
> > +# Do checkpoint
> > +#
> > +# Returns: nothing
> > +#
> > +# Since: 2.8
> Again, should be 2.9

I will fix this in next version.

Thanks
Zhang Chen

> > +##
> > +{ 'command': 'xen-do-checkpoint' }
> > +
> > +##
> >   # @GICCapability:
> >   #
> >   # The struct describes capability for a specific GIC (Generic

--
Thanks
zhangchen