[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des |
Date: |
Mon, 5 Dec 2016 09:25:43 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Mon, Dec 05, 2016 at 04:59:39PM +0800, Longpeng(Mike) wrote:
> The cryptodev use DES-RFB for ecb(des) currently, we should use
> standard DES for cryptodev instead.
>
> Signed-off-by: Longpeng(Mike) <address@hidden>
> ---
> backends/cryptodev-builtin.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c
> index ecad565..f1b5b1b 100644
> --- a/backends/cryptodev-builtin.c
> +++ b/backends/cryptodev-builtin.c
> @@ -207,7 +207,7 @@ static int cryptodev_builtin_create_cipher_session(
> break;
> case VIRTIO_CRYPTO_CIPHER_DES_ECB:
> mode = QCRYPTO_CIPHER_MODE_ECB;
> - algo = QCRYPTO_CIPHER_ALG_DES_RFB;
> + algo = QCRYPTO_CIPHER_ALG_DES;
> break;
> default:
> error_setg(errp, "Unsupported cipher alg :%u",
This will need updating due to my suggestion to change the enum name, but
regardless this fix is clearly needed - we don't want cryptodev using the
VNC custom bit-reversed single-DES
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
- [Qemu-devel] [PATCH for-2.9 0/3] crypto: add standard des support, Longpeng(Mike), 2016/12/05
- [Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des, Longpeng(Mike), 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Longpeng(Mike), 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Daniel P. Berrange, 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Gonglei (Arei), 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Daniel P. Berrange, 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Gonglei (Arei), 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Daniel P. Berrange, 2016/12/06
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Gonglei (Arei), 2016/12/06
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Longpeng (Mike), 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Daniel P. Berrange, 2016/12/05
Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Eric Blake, 2016/12/05