Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

[Longpeng (Mike)]

Hi Daniel,

On 2016/12/5 17:18, Daniel P. Berrange wrote:

> On Mon, Dec 05, 2016 at 04:59:38PM +0800, Longpeng(Mike) wrote:
......
>> diff --git a/qapi/crypto.json b/qapi/crypto.json
>> index 5c9d7d4..d403ab9 100644
>> --- a/qapi/crypto.json
>> +++ b/qapi/crypto.json
>> @@ -75,7 +75,7 @@
>>  { 'enum': 'QCryptoCipherAlgorithm',
>>    'prefix': 'QCRYPTO_CIPHER_ALG',
>>    'data': ['aes-128', 'aes-192', 'aes-256',
>> -           'des-rfb',
>> +           'des-rfb', 'des',
> 
> Can we call this '3des' to make it clear that this is Triple-DES and not
> the single-DES (which des-rfb is)
> 

As the comment in qapi/crypto.json said:
@des-rfb: RFB specific variant of single DES.

This patch just add the standard single-DES support, not the triple-DES, so I
think maybe "des" is suitable.

And we will add "3des" in the near-future.

>>             'cast5-128',
>>             'serpent-128', 'serpent-192', 'serpent-256',
>>             'twofish-128', 'twofish-192', 'twofish-256']}
> 
> Regards,
> Daniel


-- 
Regards,
Longpeng(Mike)