[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH for 2.9] gdbstub: remove spurious tb_flush()
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH for 2.9] gdbstub: remove spurious tb_flush() calls |
|
Date: |
Tue, 6 Dec 2016 08:47:46 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 12/06/2016 07:42 AM, Peter Maydell wrote:
> I also think that cpu_single_step() doing a flush is wrong:
> we should have the singlestep flag in the tbflags instead.
Yes. And the parallel_cpus flag, so we don't have to keep re-translating an
instruction that cannot be handled by the host natively.
Indeed, it occurs to me that we could steal some bits out of cflags to
represent both of these, and then include cflags in the hash.
r~