Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] Remove need for -iscsi argument

[Kevin Wolf]

Am 08.12.2016 um 13:41 hat Daniel P. Berrange geschrieben:
> This small series removes the need for using the -iscsi argument
> by directly supporting all the -iscsi options against the block
> device config eg instead of
> 
> $QEMU \
>   -object secret,id=sec0,data=123456 \
>   -drive driver=iscsi,file=iscsi://catbus/iqn.fedora:kvm/2 \
>   -iscsi initiator-name=fish,user=test,password-secret=sec0,timeout=234 
> 
> you can now do it all against -drive
> 
> $QEMU \
>   -object secret,id=sec0,data=123456 \
>   -drive driver=iscsi,file=iscsi://catbus/iqn.fedora:kvm/2,\
>          initiator-name=fish,user=test,password-secret=sec0,timeout=234 
> 
> This fixes the problem that you cannot associate -drive instances
> with -iscsi args reliably due to IQNs containing chracters that
> QEMU forbids in QemuOpts ID strings.
> 
> Pino had previously sent a patch to do this for initiator-name
> back in the 2.6 dev cycle
> 
>   https://lists.nongnu.org/archive/html/qemu-block/2016-04/msg00246.html
> 
> This series supports all the -iscsi option names, except for
> 'password' which is intentionally left out as it is insecure
> and replaced by 'password-secret'.

I actually do the same as part of my iscsi for blockdev-add series,
which I guess I better should have sent as an RFC even if it's yet
untested to save you the work...

As I do more on top of just converting -iscsi, I would prefer using my
patches even if you posted yours first.

Kevin