Re: [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6dd47da char: headers clean-up
eae63eb char: move parallel chardev in its own file
513bbbd char: move serial chardev to itw own file
2aad2df char: move pty chardev in its own file
ca281a9 char: move pipe chardev in its own file
7badddb char: move console in its own file
647d879 char: move stdio in its own file
55a7839 char: move file chardev in its own file
c1d5963 char: move udp chardev in its own file
ca11e13 char: move socket chardev to itw own file
ff7313b char: move win-stdio into its own file
4c6498d char: move win chardev base class in its own file
33aaee6 char: move fd chardev in its own file
4de906b char: move QIOChannel-related in char-io.h
31c1f1a char: remove unused READ_RETRIES
4efc6d4 char: rename and move to header CHR_READ_BUF_LEN
36c17aa char: move ringbuf/memory to its own file
027ca5a char: move mux to its own file
c6d8321 char: move null chardev to its own file
d65b167 char: make null_chr_write() the default method
609664c char: create chardev-obj-y
75fcc6e char: move to chardev/
844de46 char: remove class kind field
ad2221e char: get rid of CharDriver
90b9713 char: remove chr_free
7c4855f char-fd: convert to finalize
43a0815 char-win: convert to finalize
da085e4 char-win: do not override chr_free
41c23fa char-win-stdio: convert to finalize
4fd4b2f char-stdio: convert to finalize
aa5ce7d char-parallel: convert parallel to finalize
1c19acc char-ringbuf: convert to finalize
c57180d char-pty: convert to finalize
2105b5a char-socket: convert to finalize
070b2bc char-udp: convert to finalize
40786d6 mux: convert to finalize
a14b7cc msmouse: convert to finalize
1d27cb9 baum: convert to finalize
4a16040 spice-qemu-char: convert to finalize
1b0eeaa chardev: qom-ify
1b252d2 gtk: overwrite the console.c char driver
465bb1b char: use error_report()
2f15b5a spice-char: improve error reporting
96b38bf char: rename TCPChardev and NetChardev
c4738ef char: rename CharDriverState Chardev
39e99a6 bt: use qemu_chr_alloc()
3bdbe90 char: allocate CharDriverState as a single object
495e3c5 char: use a feature bit for replay
37280da char: introduce generic qemu_chr_get_kind()
0011e50 char: fold single-user functions in caller
72464ef char: move callbacks in CharDriver
6dc33a0 char: use a static array for backends
a3e1bca char: use a const CharDriver
2ac8265 gtk: avoid oob array access

=== OUTPUT BEGIN ===
Checking PATCH 1/54: gtk: avoid oob array access...
Checking PATCH 2/54: char: use a const CharDriver...
Checking PATCH 3/54: char: use a static array for backends...
Checking PATCH 4/54: char: move callbacks in CharDriver...
WARNING: architecture specific defines should be avoided
#1106: FILE: qemu-char.c:4704:
+#if defined(__linux__)

WARNING: line over 80 characters
#1110: FILE: qemu-char.c:4708:
+#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || 
defined(__DragonFly__)

total: 0 errors, 2 warnings, 1365 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/54: char: fold single-user functions in caller...
Checking PATCH 6/54: char: introduce generic qemu_chr_get_kind()...
Checking PATCH 7/54: char: use a feature bit for replay...
Checking PATCH 8/54: char: allocate CharDriverState as a single object...
Checking PATCH 9/54: bt: use qemu_chr_alloc()...
Checking PATCH 10/54: char: rename CharDriverState Chardev...
Checking PATCH 11/54: char: rename TCPChardev and NetChardev...
Checking PATCH 12/54: spice-char: improve error reporting...
Checking PATCH 13/54: char: use error_report()...
WARNING: line over 80 characters
#61: FILE: qemu-char.c:4137:
+                g_string_append_printf(str, "\n%s", 
ChardevBackendKind_lookup[cd->kind]);

total: 0 errors, 1 warnings, 64 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/54: gtk: overwrite the console.c char driver...
Checking PATCH 15/54: chardev: qom-ify...
WARNING: architecture specific defines should be avoided
#1385: FILE: qemu-char.c:1462:
+#if defined(__linux__) || defined(__sun__) || defined(__FreeBSD__)     \

total: 0 errors, 1 warnings, 3582 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 16/54: spice-qemu-char: convert to finalize...
Checking PATCH 17/54: baum: convert to finalize...
Checking PATCH 18/54: msmouse: convert to finalize...
Checking PATCH 19/54: mux: convert to finalize...
Checking PATCH 20/54: char-udp: convert to finalize...
Checking PATCH 21/54: char-socket: convert to finalize...
Checking PATCH 22/54: char-pty: convert to finalize...
Checking PATCH 23/54: char-ringbuf: convert to finalize...
Checking PATCH 24/54: char-parallel: convert parallel to finalize...
WARNING: architecture specific defines should be avoided
#48: FILE: qemu-char.c:4696:
+#if defined(__linux__)

WARNING: line over 80 characters
#57: FILE: qemu-char.c:4705:
+#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || 
defined(__DragonFly__)

total: 0 errors, 2 warnings, 52 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 25/54: char-stdio: convert to finalize...
Checking PATCH 26/54: char-win-stdio: convert to finalize...
Checking PATCH 27/54: char-win: do not override chr_free...
Checking PATCH 28/54: char-win: convert to finalize...
Checking PATCH 29/54: char-fd: convert to finalize...
Checking PATCH 30/54: char: remove chr_free...
Checking PATCH 31/54: char: get rid of CharDriver...
Checking PATCH 32/54: char: remove class kind field...
Checking PATCH 33/54: char: move to chardev/...
Checking PATCH 34/54: char: create chardev-obj-y...
Checking PATCH 35/54: char: make null_chr_write() the default method...
Checking PATCH 36/54: char: move null chardev to its own file...
Checking PATCH 37/54: char: move mux to its own file...
Checking PATCH 38/54: char: move ringbuf/memory to its own file...
Checking PATCH 39/54: char: rename and move to header CHR_READ_BUF_LEN...
Checking PATCH 40/54: char: remove unused READ_RETRIES...
Checking PATCH 41/54: char: move QIOChannel-related in char-io.h...
Checking PATCH 42/54: char: move fd chardev in its own file...
Checking PATCH 43/54: char: move win chardev base class in its own file...
Checking PATCH 44/54: char: move win-stdio into its own file...
Checking PATCH 45/54: char: move socket chardev to itw own file...
Checking PATCH 46/54: char: move udp chardev in its own file...
Checking PATCH 47/54: char: move file chardev in its own file...
Checking PATCH 48/54: char: move stdio in its own file...
WARNING: architecture specific defines should be avoided
#271: FILE: chardev/char.c:687:
+#if defined(__linux__) || defined(__sun__) || defined(__FreeBSD__)      \

total: 0 errors, 1 warnings, 293 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 49/54: char: move console in its own file...
Checking PATCH 50/54: char: move pipe chardev in its own file...
Checking PATCH 51/54: char: move pty chardev in its own file...
WARNING: architecture specific defines should be avoided
#40: FILE: chardev/char-pty.c:11:
+#if defined(__linux__) || defined(__sun__) || defined(__FreeBSD__)      \

total: 0 errors, 1 warnings, 554 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 52/54: char: move serial chardev to itw own file...
ERROR: if this code is redundant consider removing it
#67: FILE: chardev/char-serial.c:38:
+#if 0

ERROR: braces {} are necessary for all arms of this statement
#73: FILE: chardev/char-serial.c:44:
+#define check_speed(val) if (speed <= val) { spd = B##val; break; }
[...]

total: 2 errors, 0 warnings, 647 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 53/54: char: move parallel chardev in its own file...
WARNING: architecture specific defines should be avoided
#36: FILE: chardev/char-parallel.c:7:
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)

WARNING: architecture specific defines should be avoided
#44: FILE: chardev/char-parallel.c:15:
+#ifdef __linux__

WARNING: architecture specific defines should be avoided
#53: FILE: chardev/char-parallel.c:24:
+#if defined(__linux__)

WARNING: line over 80 characters
#181: FILE: chardev/char-parallel.c:152:
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || 
defined(__DragonFly__)

WARNING: architecture specific defines should be avoided
#181: FILE: chardev/char-parallel.c:152:
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || 
defined(__DragonFly__)

WARNING: architecture specific defines should be avoided
#281: FILE: chardev/char-parallel.c:252:
+#if defined(__linux__)

WARNING: architecture specific defines should be avoided
#291: FILE: chardev/char-parallel.c:262:
+#if defined(__linux__)

WARNING: architecture specific defines should be avoided
#331: FILE: chardev/char-parallel.h:4:
+#if defined(__linux__) || defined(__FreeBSD__) || \

total: 0 errors, 8 warnings, 646 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 54/54: char: headers clean-up...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden