Re: [Qemu-devel] [PATCH for-2.9 v3 0/6] crypto: add HMAC algorithms support

[Daniel P. Berrange]

On Tue, Dec 13, 2016 at 03:35:00PM +0800, Longpeng (Mike) wrote:
> Hi Daniel,
> 
> The error is due to auto-build environment doesn't support both gcrypt and
> nettle, and it's glibc(2.28) is too old, so I think I should add no-op in
> hmac-glib.c when glibc is older than 2.30. for example:
> 
> #include <...>
> 
> #if GLIB_CHECK_VERSION(2, 30, 0)
>       ....
> #else
>       ...(no-op func)
> #endif
> 
> Do you have any suggestion ?

Yep, you need to wrap the entire hmac-glib.c file in the #if so that you
hide the method impl too.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|