[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilitie
From: |
P J P |
Subject: |
Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size |
Date: |
Tue, 13 Dec 2016 17:03:15 +0530 (IST) |
+-- On Tue, 13 Dec 2016, Pankaj Gupta wrote --+
| > + if (max_size) {
| > + resp->hdr.type = VIRTIO_GPU_RESP_OK_CAPSET;
| > + virgl_renderer_fill_caps(gc.capset_id,
| > + gc.capset_version,
| > + (void *)resp->capset_data);
| > + }
| > virtio_gpu_ctrl_response(g, cmd, &resp->hdr, sizeof(*resp) + max_size);
|
| Just one point here for 'max_size=0', do we don't require to set
resp->hdr.type?
I thought hdr.type is if capabilities data is set.
| If yes, other patch on list by 'Li Qiang' can also help to avoid sending
garbage value.
g_malloc0 one? Yes.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F