[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9 v2] Move target-* CPU file into a target
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9 v2] Move target-* CPU file into a target/ folder |
Date: |
Wed, 14 Dec 2016 16:34:55 -0500 (EST) |
> I was considering moving xen-* and kvm-* to xen/ and kvm/
> directories, but an accel/ directory would be even better. I plan
> to send a patch to do this:
>
> tcg/ => accel/tcg/
> kvm-* => accel/kvm/* (except for stubs)
> xen-* => accel/xen/* (except for stubs)
> qtest.c => accel/qtest/qtest.c
I'm not sure if tcg/ should move to accel/tcg. I was thinking of QEMU
runtime files like cpu-exec*, translate*, user-exec.c and cputlb.c.
IMO there's value in leaving the code generator separated from the
QEMU-specific stuff. I'm also not too enthusiastic about making
accel/kvm and accel/xen for respectively one and three files. :)
So maybe accel/ with accel/tcg/ inside would be enough.
(Also, tcg-runtime.c and tci.c should move to tcg/).
BTW, you can certainly move stubs to subdirectories. These are
all per-target files, so you can just leave
obj-y += accel/
in Makefile.target and move the obj-$(...) assignments to the
accel/Makefile.objs file.
Paolo