[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] qmp/hmp: add set-vm-generation-id commands
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] qmp/hmp: add set-vm-generation-id commands |
Date: |
Tue, 20 Dec 2016 08:36:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 12/19/2016 04:46 PM, address@hidden wrote:
> From: Igor Mammedov <address@hidden>
>
> Add set-vm-generation-id command to set Virtual Machine
> Generation ID counter.
>
> QMP command example:
> { "execute": "set-vm-generation-id",
> "arguments": {
> "changed": true,
> "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87"
> }
> }
>
> HMP command example:
> set-vm-generation-id changed=true
> guid=324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87
>
> Signed-off-by: Ben Warren <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: Eric Blake <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -4796,3 +4796,15 @@
> # Since 2.9
> ##
> { 'command': 'query-vm-generation-id', 'returns': 'GuidInfo' }
> +
> +##
> +# @set-vm-generation-id
> +#
> +# Set Virtual Machine Generation ID
> +#
> +# @changed: Is the Virtual Machine Generation ID a new value?
> +# @guid: new GUID to set as Virtual Machine Generation ID
> +#
> +# Since 2.9
> +##
> +{ 'command': 'set-vm-generation-id', 'data': { 'changed': 'bool', 'guid':
> 'str' } }
When should 'changed' ever be set to false? Should it be an optional
parameter, defaulting to true, if it is even needed?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID, ben, 2016/12/19
- [Qemu-devel] [PATCH 1/5] docs: vm generation id device's description, ben, 2016/12/19
- [Qemu-devel] [PATCH 4/5] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands, ben, 2016/12/19
- [Qemu-devel] [PATCH 5/5] qmp/hmp: add set-vm-generation-id commands, ben, 2016/12/19
- Re: [Qemu-devel] [PATCH 5/5] qmp/hmp: add set-vm-generation-id commands,
Eric Blake <=
- [Qemu-devel] [PATCH 3/5] ACPI: Add Virtual Machine Generation ID support, ben, 2016/12/19
- [Qemu-devel] [PATCH 2/5] ACPI: Add a function for building named qword entries, ben, 2016/12/19
- Re: [Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID, no-reply, 2016/12/20