Re: [Qemu-devel] [PATCH for-2.9 01/10] tests: pc: add memory hotplug acpi tables tests

[Igor Mammedov]

On Tue, 20 Dec 2016 12:40:21 +0200
Marcel Apfelbaum <address@hidden> wrote:

> On 12/06/2016 01:32 AM, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> >  tests/bios-tables-test.c | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> > index 812f830..5404805 100644
> > --- a/tests/bios-tables-test.c
> > +++ b/tests/bios-tables-test.c
> > @@ -867,6 +867,28 @@ static void test_acpi_piix4_tcg_ipmi(void)
> >      free_test_data(&data);
> >  }
> >
> 
> Hi Igor,
> 
> 
> > +static void test_acpi_q35_tcg_memhp(void)
> > +{
> > +    test_data data;
> > +
> > +    memset(&data, 0, sizeof(data));
> > +    data.machine = MACHINE_Q35;
> > +    data.variant = ".memhp";
> > +    test_acpi_one(" -m 128,slots=3,maxmem=1G -numa node", &data);
> 
> Why do we need the "-numa node" ? (I am sure you put it there for a reason, 
> but I don't know it :))
I added it to expose SRAT table to guest
so we could detect unexpected changes caused by memory hotplug changes

> 
> Thanks,
> Marcel
> 
> > +    free_test_data(&data);
> > +}
> > +
> > +static void test_acpi_piix4_tcg_memhp(void)
> > +{
> > +    test_data data;
> > +
> > +    memset(&data, 0, sizeof(data));
> > +    data.machine = MACHINE_PC;
> > +    data.variant = ".memhp";
> > +    test_acpi_one(" -m 128,slots=3,maxmem=1G -numa node", &data);
> > +    free_test_data(&data);
> > +}
> > +
> >  int main(int argc, char *argv[])
> >  {
> >      const char *arch = qtest_get_arch();
> > @@ -887,6 +909,8 @@ int main(int argc, char *argv[])
> >          qtest_add_func("acpi/q35/ipmi", test_acpi_q35_tcg_ipmi);
> >          qtest_add_func("acpi/piix4/cpuhp", test_acpi_piix4_tcg_cphp);
> >          qtest_add_func("acpi/q35/cpuhp", test_acpi_q35_tcg_cphp);
> > +        qtest_add_func("acpi/piix4/memhp", test_acpi_piix4_tcg_memhp);
> > +        qtest_add_func("acpi/q35/memhp", test_acpi_q35_tcg_memhp);
> >      }
> >      ret = g_test_run();
> >      boot_sector_cleanup(disk);
> >