[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 4/7] kvm: Include kvm-stub.o only on CONFIG_SOFTMM
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [RFC 4/7] kvm: Include kvm-stub.o only on CONFIG_SOFTMMU |
Date: |
Wed, 21 Dec 2016 08:27:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 20.12.2016 18:43, Eduardo Habkost wrote:
> Now the stubs required by *-user are inside stubs/kvm.c, so
> kvm-stub.c is needed only by CONFIG_SOFTMMU.
>
> Cc: Paolo Bonzini <address@hidden>
> Cc: address@hidden
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Makefile.target | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 0b2ad86..5e78bb0 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -96,7 +96,6 @@ obj-y += target-$(TARGET_BASE_ARCH)/
> obj-y += disas.o
> obj-y += tcg-runtime.o
> obj-$(call notempty,$(TARGET_XML_FILES)) += gdbstub-xml.o
> -obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
>
> obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decContext.o
> obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decNumber.o
> @@ -138,6 +137,7 @@ obj-y += arch_init.o cpus.o monitor.o gdbstub.o balloon.o
> ioport.o numa.o
> obj-y += qtest.o bootdevice.o
> obj-y += hw/
> obj-$(CONFIG_KVM) += kvm-all.o
> +obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
> obj-y += memory.o cputlb.o
> obj-y += memory_mapping.o
> obj-y += dump.o
<bikeshedding>
IMHO you could also squash this change into the next patch (and just
mention it in the commit description).
</bikeshedding>
Thomas
- [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir, Eduardo Habkost, 2016/12/20
- [Qemu-devel] [RFC 2/7] xen: Move xen files to accel/, Eduardo Habkost, 2016/12/20
- [Qemu-devel] [RFC 1/7] xen: Move xen-*-stub.c to stubs/, Eduardo Habkost, 2016/12/20
- [Qemu-devel] [RFC 3/7] kvm: Move some kvm-stub.c code to stubs/kvm.c, Eduardo Habkost, 2016/12/20
- [Qemu-devel] [RFC 4/7] kvm: Include kvm-stub.o only on CONFIG_SOFTMMU, Eduardo Habkost, 2016/12/20
- Re: [Qemu-devel] [RFC 4/7] kvm: Include kvm-stub.o only on CONFIG_SOFTMMU,
Thomas Huth <=
- [Qemu-devel] [RFC 5/7] kvm: Move kvm*.c files to accel/, Eduardo Habkost, 2016/12/20
- [Qemu-devel] [RFC 6/7] accel: Move accel.c to accel/, Eduardo Habkost, 2016/12/20
- [Qemu-devel] [RFC 7/7] accel: Move qtest.c to accel/, Eduardo Habkost, 2016/12/20
- Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir, Stefan Weil, 2016/12/20
- Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir, Stefano Stabellini, 2016/12/20
- Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir, Thomas Huth, 2016/12/21
- Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir, Paolo Bonzini, 2016/12/21