[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] qqq: module for synchronizing with a simulat
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v4] qqq: module for synchronizing with a simulation clock |
Date: |
Tue, 27 Dec 2016 12:16:05 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v4] qqq: module for synchronizing with a
simulation clock
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
62b7e47 qqq: module for synchronizing with a simulation clock
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qqq: module for synchronizing with a simulation clock...
ERROR: spaces required around that '-' (ctx:VxV)
#197: FILE: include/qemu/timer.h:816:
+ return ((tv.tv_sec * 1000000000LL + (tv.tv_usec * 1000))-get_iced_ns());
^
ERROR: return is not a function, parentheses are not required
#197: FILE: include/qemu/timer.h:816:
+ return ((tv.tv_sec * 1000000000LL + (tv.tv_usec * 1000))-get_iced_ns());
ERROR: spaces required around that '-' (ctx:VxV)
#210: FILE: include/qemu/timer.h:845:
+ return (ts.tv_sec * 1000000000LL + ts.tv_nsec)-get_iced_ns();
^
ERROR: suspect code indent for conditional statements (4, 9)
#218: FILE: include/qemu/timer.h:896:
+ if (ticks_is_frozen() > 0) {
+ return ticks_is_frozen();
ERROR: spaces required around that '-' (ctx:VxV)
#223: FILE: include/qemu/timer.h:900:
+ return val-get_iced_ticks();
^
ERROR: suspect code indent for conditional statements (4, 9)
#231: FILE: include/qemu/timer.h:909:
+ if (ticks_is_frozen() > 0) {
+ return ticks_is_frozen();
ERROR: spaces required around that '-' (ctx:VxV)
#239: FILE: include/qemu/timer.h:916:
+ return val-get_iced_ticks();
^
ERROR: suspect code indent for conditional statements (4, 9)
#247: FILE: include/qemu/timer.h:933:
+ if (ticks_is_frozen() > 0) {
+ return ticks_is_frozen();
ERROR: spaces required around that '-' (ctx:VxV)
#252: FILE: include/qemu/timer.h:937:
+ return val-get_iced_ticks();
^
ERROR: do not initialise statics to 0 or NULL
#349: FILE: qqq.c:15:
+static bool enabled = false, syncing = false;
ERROR: do not use C99 // comments
#350: FILE: qqq.c:16:
+static int elapsed; // This must be zero on initialization
ERROR: trailing whitespace
#405: FILE: qqq.c:71:
+ if (time_advance < 0) $
ERROR: braces {} are necessary for all arms of this statement
#405: FILE: qqq.c:71:
+ if (time_advance < 0)
[...]
WARNING: line over 80 characters
#425: FILE: qqq.c:91:
+ /* Set the sync flag that will cause the vcpu to wait for
synchronization
total: 13 errors, 1 warnings, 519 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden