qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] reuse user_creatable_add_opts() instead of

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 2/3] reuse user_creatable_add_opts() instead of user_creatable_add() in monitor
Date: Tue, 3 Jan 2017 09:29:11 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 
On 01/02/2017 09:44 AM, Igor Mammedov wrote:
> Simplify code by dropping ~57LOC by merging user_creatable_add()
> into user_creatable_add_opts() and using the later from monutor.
> Along with it allocate opts_visitor_new() once in user_creatable_add_opts().
> 
> As result we have one less API func and a more readable/simple
> user_creatable_add_opts() vs user_creatable_add().
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to
[Prev in Thread] Current Thread [Next in Thread]