[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support |
Date: |
Fri, 6 Jan 2017 18:59:19 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* address@hidden (address@hidden) wrote:
> Hi,
> Checking PATCH 14/15: postcopy: Check for userfault+hugepage feature...
> ERROR: trailing whitespace
> #21: FILE: migration/postcopy-ram.c:85:
> + bool have_hp = false; $
I noticed that one but explicitly left it; the code really reads much
more cleanly to me with it explicitly set.
Dave
> total: 1 errors, 0 warnings, 17 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Checking PATCH 15/15: postcopy: Add doc about hugepages and postcopy...
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 07/15] postcopy: Plumb pagesize down into place helpers, (continued)
- [Qemu-devel] [PATCH 09/15] postcopy: Load huge pages in one go, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 10/15] postcopy: Mask fault addresses to huge page boundary, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 11/15] postcopy: Send whole huge pages, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 12/15] postcopy: Allow hugepages, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 13/15] postcopy: Update userfaultfd.h header, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 14/15] postcopy: Check for userfault+hugepage feature, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 15/15] postcopy: Add doc about hugepages and postcopy, Dr. David Alan Gilbert (git), 2017/01/06
- Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support, no-reply, 2017/01/06
- Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support,
Dr. David Alan Gilbert <=
- Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support, no-reply, 2017/01/06