[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] ui: fix format specifier in vnc_client_io_error() t
From: |
Rami Rosen |
Subject: |
[Qemu-devel] [PATCH] ui: fix format specifier in vnc_client_io_error() to avoid break in build. |
Date: |
Sun, 8 Jan 2017 20:28:43 +0200 |
When building qemu after setting _VNC_DEBUG to 1 (see ui/vnc.h),
we get the following error and the build breaks:
...
ui/vnc.c: In function ‘vnc_client_io_error’:
ui/vnc.c:1262:13: error: format ‘%d’ expects argument of type ‘int’, but
argument 3 has type ‘ssize_t’ [-Werror=format=]
VNC_DEBUG("Closing down client sock: ret %d (%s)\n",
^
cc1: all warnings being treated as errors
make: *** [ui/vnc.o] Error 1
...
This patch solves this issue by fixing the print format specifier
in vnc_client_io_error() to be %ld, which corresponds to the type
of the "ret" variable.
Signed-off-by: Rami Rosen <address@hidden>
---
ui/vnc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 2c28a59..4b0a89c 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -1259,7 +1259,7 @@ ssize_t vnc_client_io_error(VncState *vs, ssize_t ret,
Error **errp)
if (ret == 0) {
VNC_DEBUG("Closing down client sock: EOF\n");
} else if (ret != QIO_CHANNEL_ERR_BLOCK) {
- VNC_DEBUG("Closing down client sock: ret %d (%s)\n",
+ VNC_DEBUG("Closing down client sock: ret %ld (%s)\n",
ret, errp ? error_get_pretty(*errp) : "Unknown");
}
--
1.9.1
- [Qemu-devel] [PATCH] ui: fix format specifier in vnc_client_io_error() to avoid break in build.,
Rami Rosen <=