[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] fix qmp/hmp query-memdev not reporting I
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] fix qmp/hmp query-memdev not reporting IDs of memory backends |
Date: |
Tue, 10 Jan 2017 08:49:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/10/2017 06:53 AM, Igor Mammedov wrote:
> Considering 'id' is mandatory for user_creatable objects/backends
> and user_creatable_add_type() always has it as an argument
> regardless of where from it is called CLI/monitor or QMP,
> Fix issue by adding 'id' property to hostmem backends and
> set it in user_creatable_add_type() for every object that
> implements 'id' property. Then later at query-memdev time
> get 'id' from object directly.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> include/sysemu/hostmem.h | 1 +
> backends/hostmem.c | 26 ++++++++++++++++++++++++++
> docs/qmp-commands.txt | 1 +
> hmp.c | 5 +----
> numa.c | 3 +++
> qapi-schema.json | 3 +++
> qom/object_interfaces.c | 6 ++++++
> 7 files changed, 41 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature