[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/8] io: add ability to associate an error wi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/8] io: add ability to associate an error with a task |
Date: |
Tue, 10 Jan 2017 08:55:23 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/09/2017 09:39 AM, Daniel P. Berrange wrote:
> Currently when a task fails, the error is never explicitly
> associated with the task object, it is just passed along
> through the completion callback. This adds the ability to
> explicitly associate an error with the task.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> include/io/task.h | 32 ++++++++++++++++++++++++++++++++
> io/task.c | 23 +++++++++++++++++++++++
> 2 files changed, 55 insertions(+)
>
> /**
> + * qio_task_set_error:
> + * @task: the task struct
> + * @err: pointer to the error, or NULL
> + *
> + * Associate an error with the task, which can later
> + * be retrieved with the qio_task_propagate_error()
> + * method. This method takes ownership of @err, so
> + * it is not valid to access it after this call
> + * completes. If @err is NULL this is a no-op. If
> + * this is call multiple times, only the first
s/call/called/
> + * provided @err will be recorded, later ones will
> + * be discarded and freed.
> + */
With the typo fix,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/8] io: enable DNS resolving separately of socket create, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 3/8] io: fix typo in docs for QIOTask, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 2/8] io: stop incrementing reference in qio_task_get_source, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 4/8] io: add ability to associate an opaque "result" with with a task, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 5/8] io: add ability to associate an error with a task, Daniel P. Berrange, 2017/01/09
- Re: [Qemu-devel] [PATCH v2 5/8] io: add ability to associate an error with a task,
Eric Blake <=
- [Qemu-devel] [PATCH v2 7/8] io: remove Error parameter from QIOTask thread worker, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 6/8] io: change the QIOTask callback signature, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 8/8] io: introduce a DNS resolver API, Daniel P. Berrange, 2017/01/09