Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file

[Stefan Hajnoczi]

On Fri, Jan 06, 2017 at 03:54:58PM +0000, Daniel P. Berrange wrote:
> diff --git a/io/channel-buffer.c b/io/channel-buffer.c
> index 43d7959..b4e50d6 100644
> --- a/io/channel-buffer.c
> +++ b/io/channel-buffer.c
> @@ -22,7 +22,7 @@
>  #include "io/channel-buffer.h"
>  #include "io/channel-watch.h"
>  #include "qemu/sockets.h"
> -#include "trace.h"
> +#include "io/trace.h"

Is this change necessary?

I think the per-subdir trace.h file should be generated in
$BUILD_DIR/<sub-dir>/trace.h and gcc -I. can locate that file.

Stefan

signature.asc
Description: PGP signature