[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/20] char: use a const CharDriver
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/20] char: use a const CharDriver |
Date: |
Tue, 10 Jan 2017 12:01:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/10/2017 11:47 AM, Marc-André Lureau wrote:
> No need to allocate & copy fields, let's use static const struct
> instead.
Missing these sentences:
Add an alias field to the CharDriver structure to cover the cases where
we previously registered a driver twice under two names. The name field
is no longer necessary, since we can now use a QAPI enum lookup.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
R-by stands, just the commit message needs improvement.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/20] chardev: qom-ify, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 02/20] qemu-options: stdio is available on win32, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 01/20] tests: fix linking test-char on win32, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 03/20] char: add qemu_chr_fe_add_watch() Returns description, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 04/20] doc: fix spelling, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 05/20] char: use a const CharDriver, Marc-André Lureau, 2017/01/10
- Re: [Qemu-devel] [PATCH v2 05/20] char: use a const CharDriver,
Eric Blake <=
- [Qemu-devel] [PATCH v2 06/20] char: use a static array for backends, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 08/20] char: fold single-user functions in caller, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 09/20] char: introduce generic qemu_chr_get_kind(), Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 10/20] char: use a feature bit for replay, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 07/20] char: move callbacks in CharDriver, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 12/20] bt: use qemu_chr_alloc(), Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 14/20] char: rename TCPChardev and NetChardev, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 15/20] spice-char: improve error reporting, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 11/20] char: allocate CharDriverState as a single object, Marc-André Lureau, 2017/01/10