Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file

[Daniel P. Berrange]

On Wed, Jan 11, 2017 at 10:28:32AM +0000, Daniel P. Berrange wrote:
> On Tue, Jan 10, 2017 at 10:01:12PM +0100, Paolo Bonzini wrote:
> > 
> > 
> > On 10/01/2017 19:36, Daniel P. Berrange wrote:
> > > 
> > > It seems you're saying we should also trim the top level dirs, so
> > > we in fact get:
> > > 
> > > 
> > > -I/home/berrange/src/virt/qemu/hw/scsi
> > > -Ihw/scsi
> > > -I/home/berrange/src/virt/qemu/tcg
> > > -I/home/berrange/src/virt/qemu/tcg/i386
> > > -I/home/berrange/src/virt/qemu/linux-headers
> > > -I/home/berrange/src/virt/qemu-build/linux-headers
> > > -I/home/berrange/src/virt/qemu/include
> > 
> > Yes, and ultimately tcg too.
> 
> So the problem with dropping BUILD_DIR from the include path is that
> config-host.h is generated in that location. We'll have to move that
> into BIULD_DIR/include and add -I$(BUILDDIR)/include to search path
> instead.

Sigh and much more needs moving too...

        module_block.h
        qapi-event.h
        qapi-types.h
        qapi-visit.h
        qemu-doc.html
        qemu-version.h
        qemu-version.h.tmp
        qmp-commands.h
        qmp-introspect.h

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|