Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file

[Daniel P. Berrange]

On Tue, Jan 10, 2017 at 04:38:58PM +0000, Stefan Hajnoczi wrote:
> On Fri, Jan 06, 2017 at 03:54:58PM +0000, Daniel P. Berrange wrote:
> > diff --git a/io/Makefile.objs b/io/Makefile.objs
> > index 9d8337d..94cb74e 100644
> > --- a/io/Makefile.objs
> > +++ b/io/Makefile.objs
> > @@ -8,3 +8,5 @@ io-obj-y += channel-watch.o
> >  io-obj-y += channel-websock.o
> >  io-obj-y += channel-util.o
> >  io-obj-y += task.o
> > +trace-obj-y += trace.o
> > +trace-obj-$(CONFIG_TRACE_DTRACE) += trace-dtrace.o
> 
> Is there a way to eliminate this boilerplate?  If the directory has a
> trace-events file then it requires trace.o/trace-dtrace.o.

Yes in fact. I figured out a rule in the top level Makefile.objs that can
do this for all sub-dirs

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|