[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 20/20] chardev: qom-ify
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 20/20] chardev: qom-ify |
Date: |
Wed, 11 Jan 2017 15:27:20 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/10/2017 11:48 AM, Marc-André Lureau wrote:
> Turn Chardev into Object.
>
> qemu_chr_alloc() is replaced by the qemu_chardev_new() constructor. It
> will call qemu_char_open() to open/intialize the chardev with the
> ChardevCommon *backend settings.
>
> -ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
> - Error **errp)
> +static const ChardevClass *char_get_class(const char *driver, Error **errp)
> +{
Your followup "[PATCH 16/40] char: get rid of CharDriver" hoists this up
earlier in the file. Can you minimize churn by just declaring it earlier
to begin with?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 12/20] bt: use qemu_chr_alloc(), (continued)
- [Qemu-devel] [PATCH v2 12/20] bt: use qemu_chr_alloc(), Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 14/20] char: rename TCPChardev and NetChardev, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 15/20] spice-char: improve error reporting, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 11/20] char: allocate CharDriverState as a single object, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 18/20] baum: use a common prefix for chr callbacks, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 17/20] gtk: overwrite the console.c char driver, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 16/20] char: use error_report(), Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 19/20] vc: use a common prefix for chr callbacks, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 13/20] char: rename CharDriverState Chardev, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 20/20] chardev: qom-ify, Marc-André Lureau, 2017/01/10
- Re: [Qemu-devel] [PATCH v2 20/20] chardev: qom-ify,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 00/20] chardev: qom-ify, Paolo Bonzini, 2017/01/24