Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file

[Lluís Vilanova]

Paolo Bonzini writes:
[...]
> A weird idea: what about doing

>     -DGENERATED_TRACERS_H=\"hw/scsi/generated-tracers.h\"

> and then having

>      #ifdef GENERATED_TRACE_H
>      #include GENERATED_TRACE_H
>      #endif

> in include/trace.h?

> Then you can use full include path for special cases such as
> include/hw/xen/xen_common.h, but the common case is handled directly
> with just

>      #include "trace.h"

> which refers to $(srcdir)/include/trace.h? (Take the above with a grain
> of salt because I haven't reviewed the patches closely).

Feels like too much black magic to me for the benefit of a bit less typing.


Cheers,
  Lluis