[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] nvdimm acpi: fix g_array_free() with NULL point
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] nvdimm acpi: fix g_array_free() with NULL pointer |
|
Date: |
Thu, 12 Jan 2017 10:58:54 +0000 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, Jan 11, 2017 at 09:44:43AM +0000, Stefan Hajnoczi wrote:
> Unlike g_free(), g_array_free() does not accept a NULL pointer argument.
> The following error is logged when an nvdimm device is realized:
>
> GLib-CRITICAL **: g_array_free: assertion 'array' failed
>
> Cc: Xiao Guangrong <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/acpi/nvdimm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
NACK
Guangrong pointed out this patch is masking another bug. There seems to
be a problem with the order in which functions are called when the
device is realized.
signature.asc
Description: PGP signature