[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 2/7] trace: Make trace_get_vcpu_event_count()
|
From: |
Lluís Vilanova |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 2/7] trace: Make trace_get_vcpu_event_count() inlinable |
|
Date: |
Thu, 12 Jan 2017 19:14:19 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Richard Henderson writes:
> On 12/28/2016 10:41 AM, Lluís Vilanova wrote:
>> @@ -82,6 +83,10 @@ static inline bool
>> trace_event_get_vcpu_state_dynamic(CPUState *vcpu,
>> return trace_event_get_vcpu_state_dynamic_by_vcpu_id(vcpu, vcpu_id);
>> }
>>
>> +static inline uint32_t trace_get_vcpu_event_count(void)
>> +{
>> + return trace_next_vcpu_id;
>> +}
> ...
>> @@ -237,7 +237,7 @@ char *trace_opt_parse(const char *optarg);
>> *
>> * Return the number of known vcpu-specific events
>> */
>> -uint32_t trace_get_vcpu_event_count(void);
>> +static uint32_t trace_get_vcpu_event_count(void);
> This second declaration should be removed.
I don't think so. "trace/control.h" contains declarations and documentation,
while "trace/control-internal.h" contains inlined implementations (something
followed by many other functions there).
Thanks,
Lluis