[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notificatio
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting |
Date: |
Thu, 12 Jan 2017 22:05:20 +0200 |
On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote:
> On 1/12/17 5:46 AM, Stefan Hajnoczi wrote:
> > The virtio_queue_set_notification() nesting introduced for AioContext
> > polling
> > raised an assertion with virtio-net (even in non-polling mode). Converting
> > virtio-net and virtio-crypto to use virtio_queue_set_notification() in a
> > nesting fashion would be invasive and isn't worth it.
> >
> > Patch 1 contains the revert to resolve the bug that Doug noticed.
> >
> > Patch 2 is a less efficient but safe alternative.
> >
> > Stefan Hajnoczi (2):
> > Revert "virtio: turn vq->notification into a nested counter"
> > virtio: disable notifications again after poll succeeded
> >
> > hw/virtio/virtio.c | 21 +++++++++------------
> > 1 file changed, 9 insertions(+), 12 deletions(-)
> >
>
> So I just gave this series a whirl and it fixes the assert but causes
> another issue for me. While iPXE is getting a DHCP address the screen
> immediately flashes over to the UEFI shell. Its like a timeout is
> getting hit and just dropping me to the shell.
>
> --
> Doug Goldstein
>
Is this just with UEFI or with seabios as well?
--
MST
- [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Stefan Hajnoczi, 2017/01/12
- [Qemu-devel] [PATCH 1/2] Revert "virtio: turn vq->notification into a nested counter", Stefan Hajnoczi, 2017/01/12
- [Qemu-devel] [PATCH 2/2] virtio: disable notifications again after poll succeeded, Stefan Hajnoczi, 2017/01/12
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Doug Goldstein, 2017/01/12
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Stefan Hajnoczi, 2017/01/13
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Doug Goldstein, 2017/01/13
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Stefan Hajnoczi, 2017/01/16
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Doug Goldstein, 2017/01/16
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Michael S. Tsirkin, 2017/01/16
- Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Stefan Hajnoczi, 2017/01/17
Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Richard Henderson, 2017/01/13
Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting, Laszlo Ersek, 2017/01/16