[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/67] ppc-for-2.9 queue 20170112
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PULL 00/67] ppc-for-2.9 queue 20170112 |
Date: |
Fri, 13 Jan 2017 10:36:48 +1100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, Jan 11, 2017 at 07:42:04PM -0800, address@hidden wrote:
> Hi,
>
> Your series seems to have some coding style problems. See output below for
> more information:
I don't think this is a real problem:
> Checking PATCH 46/67: target-ppc: Add xxextractuw instruction...
> ERROR: Macros with complex values should be enclosed in parenthesis
> #110: FILE: target/ppc/translate/vsx-ops.inc.c:52:
> +#define GEN_XX2FORM_EXT(name, opc2, opc3, fl2) \
> +GEN_HANDLER2_E(name, #name, 0x3C, opc2 | 0, opc3, 0x00100000, PPC_NONE,
> fl2), \
> +GEN_HANDLER2_E(name, #name, 0x3C, opc2 | 1, opc3, 0x00100000, PPC_NONE, fl2)
>
> total: 1 errors, 0 warnings, 92 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
This is the standard problem with checkpatch getting confused by the
ugly, ugly macros in the instruction decode stuff. Maybe we'll fix
that one day, but it's not a priority, and it's definitely out of
scope for this patch.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PULL 65/67] target-ppc: Add xscvqpdp instruction, (continued)
- [Qemu-devel] [PULL 65/67] target-ppc: Add xscvqpdp instruction, David Gibson, 2017/01/11
- [Qemu-devel] [PULL 52/67] target-ppc: Replace isden by float64_is_zero_or_denormal, David Gibson, 2017/01/11
- [Qemu-devel] [PULL 48/67] prep: add PReP System I/O, David Gibson, 2017/01/11
- [Qemu-devel] [PULL 66/67] ppc: Prevent inifnite loop in decrementer auto-reload., David Gibson, 2017/01/11
- [Qemu-devel] [PULL 53/67] target-ppc: Rename helper_compute_fprf to helper_compute_fprf_float64, David Gibson, 2017/01/11
- [Qemu-devel] [PULL 55/67] target-ppc: Use correct precision for FPRF setting, David Gibson, 2017/01/11
- [Qemu-devel] [PULL 63/67] target-ppc: Add xsaddqp instructions, David Gibson, 2017/01/11
- [Qemu-devel] [PULL 54/67] target-ppc: Add xscvdphp, xscvhpdp, David Gibson, 2017/01/11
- [Qemu-devel] [PULL 61/67] pseries: Rewrite CAS PVR compatibility logic, David Gibson, 2017/01/11
- Re: [Qemu-devel] [PULL 00/67] ppc-for-2.9 queue 20170112, no-reply, 2017/01/11
- Re: [Qemu-devel] [PULL 00/67] ppc-for-2.9 queue 20170112,
David Gibson <=
- Re: [Qemu-devel] [PULL 00/67] ppc-for-2.9 queue 20170112, Peter Maydell, 2017/01/13