[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging
From: |
Haozhong Zhang |
Subject: |
[Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging |
Date: |
Fri, 13 Jan 2017 19:56:51 +0800 |
The missing of 'nvdimm' in the machine type option '-M' means NVDIMM
is disabled. QEMU should refuse to plug any NVDIMM device in this case
and report the misconfiguration.
Reported-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Haozhong Zhang <address@hidden>
Message-Id: address@hidden
Message-Id: address@hidden
---
hw/i386/pc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 25e8586..3907609 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1715,6 +1715,11 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,
}
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
+ if (!pcms->acpi_nvdimm_state.is_enabled) {
+ error_setg(&local_err,
+ "nvdimm is not enabled: missing 'nvdimm' in '-M'");
+ goto out;
+ }
nvdimm_plug(&pcms->acpi_nvdimm_state);
}
--
2.10.1
- [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging,
Haozhong Zhang <=
Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging, Stefan Hajnoczi, 2017/01/23