[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 29/40] char: move win chardev base class in its
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 29/40] char: move win chardev base class in its own file |
Date: |
Fri, 13 Jan 2017 13:51:29 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/11/2017 11:29 AM, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> chardev/char-win.h | 30 ++++++
> chardev/char-win.c | 242 +++++++++++++++++++++++++++++++++++++++++++++++
> chardev/char.c | 253
> +-------------------------------------------------
> chardev/Makefile.objs | 1 +
> 4 files changed, 276 insertions(+), 250 deletions(-)
> create mode 100644 chardev/char-win.h
> create mode 100644 chardev/char-win.c
>
> +++ b/chardev/Makefile.objs
> @@ -4,3 +4,4 @@ chardev-obj-y += char-io.o
> chardev-obj-y += char-mux.o
> chardev-obj-y += char-null.o
> chardev-obj-y += char-ringbuf.o
> +chardev-obj-$(CONFIG_WIN32) += char-win.o
This part is the neatest - trading #ifdefs in the code for conditionally
compiling an entire .c file.
I have not closely read 28-39, so I don't know if R-b is appropriate,
but they are all mechanical and the fact that it still compiles is good.
So maybe we go with the weaker:
Acked-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 23/40] char: move mux to its own file, (continued)
- [Qemu-devel] [PATCH 26/40] char: remove unused READ_RETRIES, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 25/40] char: rename and move to header CHR_READ_BUF_LEN, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 27/40] char: move QIOChannel-related in char-io.h, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 28/40] char: move fd chardev in its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 29/40] char: move win chardev base class in its own file, Marc-André Lureau, 2017/01/11
- Re: [Qemu-devel] [PATCH 29/40] char: move win chardev base class in its own file,
Eric Blake <=
- [Qemu-devel] [PATCH 30/40] char: move win-stdio into its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 34/40] char: move stdio in its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 33/40] char: move file chardev in its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 32/40] char: move udp chardev in its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 35/40] char: move console in its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 36/40] char: move pipe chardev in its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 37/40] char: move pty chardev in its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 38/40] char: move serial chardev to itw own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 31/40] char: move socket chardev to its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 40/40] char: headers clean-up, Marc-André Lureau, 2017/01/11