[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/16] block: explicitly acquire aiocontext in c
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 11/16] block: explicitly acquire aiocontext in callbacks that need it |
Date: |
Mon, 16 Jan 2017 21:36:43 +0800 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, 01/13 14:17, Paolo Bonzini wrote:
> diff --git a/nbd/server.c b/nbd/server.c
> index efe5cb8..08fb720 100644
> --- a/nbd/server.c
> +++ b/nbd/server.c
> @@ -1366,6 +1366,10 @@ static void nbd_restart_write(void *opaque)
> static void nbd_set_handlers(NBDClient *client)
> {
> if (client->exp && client->exp->ctx) {
> + /* Note that the handlers do not expect any concurrency; qemu-nbd
> + * does not instantiate multiple AioContexts yet, nor does it call
> + * aio_poll/aio_dispatch from multiple threads.
> + */
> aio_set_fd_handler(client->exp->ctx, client->sioc->fd, true,
> client->can_read ? nbd_read : NULL,
> client->send_coroutine ? nbd_restart_write : NULL,
What about the built-in server (QMP nbd_server_start)?
> --
> 2.9.3
>
>
- [Qemu-devel] [PATCH 10/16] block: explicitly acquire aiocontext in timers that need it, (continued)
[Qemu-devel] [PATCH 12/16] block: explicitly acquire aiocontext in bottom halves that need it, Paolo Bonzini, 2017/01/13
[Qemu-devel] [PATCH 11/16] block: explicitly acquire aiocontext in callbacks that need it, Paolo Bonzini, 2017/01/13
[Qemu-devel] [PATCH 14/16] aio-posix: partially inline aio_dispatch into aio_poll, Paolo Bonzini, 2017/01/13
Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2, Fam Zheng, 2017/01/16
Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2, Stefan Hajnoczi, 2017/01/18
Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2, Stefan Hajnoczi, 2017/01/18