[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] vus: Introduce vhost-user-scsi host devi
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] vus: Introduce vhost-user-scsi host device |
|
Date: |
Mon, 16 Jan 2017 17:43:10 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 13/01/2017 01:31, Felipe Franciosi wrote:
>> Please place CONFIG_VHOST_USER_SCSI=$(CONFIG_POSIX) symbol in
>> default-configs/ (so that it is enabled by default on non-Windows hosts)
>> instead of having the configure option. Otherwise, the patches look good!
>
> Which architectures would you like me to add this to? How about putting it in
> "pci.mak"?
I think it should be in every configuration that includes virtio-scsi.
> And when you say "instead", do you mean on top of? I imagine having a
> --disable switch is at least desirable, so I'd rather not remove the commands
> from 'configure'.
No, I really meant "instead". Even though the default-configs/
mechanisms is not very user-friendly, having two ways to do
configuration is messy. Generally --disable is left for features that
require a third-party library.
Paolo