[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/11] aspeed/smc: handle SPI flash Command m
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/11] aspeed/smc: handle SPI flash Command mode |
Date: |
Fri, 20 Jan 2017 10:13:07 +0000 |
On 19 January 2017 at 20:35, Cédric Le Goater <address@hidden> wrote:
> On 01/19/2017 08:26 PM, Peter Maydell wrote:
>> On 9 January 2017 at 16:24, Cédric Le Goater <address@hidden> wrote:
>>> The Aspeed SMC controllers have a mode (Command mode) in which
>>> accesses to the flash content are no different than doing MMIOs. The
>>> controller generates all the necessary commands to load (or store)
>>> data in memory.
>>>
>>> However, accesses are restricted to the segment window assigned the
>>> the flash module by the controller. This window is defined by the
>>> Segment Address Register.
>>>
>>> Signed-off-by: Cédric Le Goater <address@hidden>
>>> Reviewed-by: Andrew Jeffery <address@hidden>
>>> ---
>>> hw/ssi/aspeed_smc.c | 152
>>> ++++++++++++++++++++++++++++++++++++++------
>>> include/hw/ssi/aspeed_smc.h | 2 +-
>>> 2 files changed, 132 insertions(+), 22 deletions(-)
>>
>> This deleted the only call to aspeed_smc_is_usermode() but not
>> its definition, which makes clang complain:
>> /Users/pm215/src/qemu-for-merges/hw/ssi/aspeed_smc.c:409:20: error:
>> unused function 'aspeed_smc_is_usermode' [-Werror,-Wunused-function]
>>
>> Presumably the function itself should be deleted?
>
> yes. This is correct. I will send a patch for it.
I'll just edit the commit in my target-arm tree, that
will be simplest.
thanks
-- PMM
- [Qemu-devel] [PATCH v2 02/11] aspeed/smc: remove call to aspeed_smc_update_cs() in reset function, (continued)
- [Qemu-devel] [PATCH v2 02/11] aspeed/smc: remove call to aspeed_smc_update_cs() in reset function, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 03/11] aspeed/smc: rework the prototype of the AspeedSMCFlash helper routines, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 04/11] aspeed/smc: autostrap CE0/1 configuration, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 05/11] aspeed/smc: unfold the AspeedSMCController array, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 06/11] aspeed/smc: adjust the size of the register region, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 07/11] aspeed/smc: handle SPI flash Command mode, Cédric Le Goater, 2017/01/09
[Qemu-devel] [PATCH v2 08/11] aspeed/smc: reset flash after each test, Cédric Le Goater, 2017/01/09
[Qemu-devel] [PATCH v2 09/11] aspeed/smc: extend tests for Command mode, Cédric Le Goater, 2017/01/09