[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v4 01/20] vfio: trace map/unmap for notify a
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [PATCH RFC v4 01/20] vfio: trace map/unmap for notify as well |
Date: |
Mon, 23 Jan 2017 11:20:22 -0700 |
On Fri, 20 Jan 2017 21:08:37 +0800
Peter Xu <address@hidden> wrote:
> We traces its range, but we don't know whether it's a MAP/UNMAP. Let's
> dump it as well.
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> hw/vfio/common.c | 3 ++-
> hw/vfio/trace-events | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
Acked-by: Alex Williamson <address@hidden>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index 801578b..174f351 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -305,7 +305,8 @@ static void vfio_iommu_map_notify(IOMMUNotifier *n,
> IOMMUTLBEntry *iotlb)
> void *vaddr;
> int ret;
>
> - trace_vfio_iommu_map_notify(iova, iova + iotlb->addr_mask);
> + trace_vfio_iommu_map_notify(iotlb->perm == IOMMU_NONE ? "UNMAP" : "MAP",
> + iova, iova + iotlb->addr_mask);
>
> if (iotlb->target_as != &address_space_memory) {
> error_report("Wrong target AS \"%s\", only system memory is allowed",
> diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events
> index ef81609..7ae8233 100644
> --- a/hw/vfio/trace-events
> +++ b/hw/vfio/trace-events
> @@ -84,7 +84,7 @@ vfio_pci_igd_lpc_bridge_enabled(const char *name) "%s"
> # hw/vfio/common.c
> vfio_region_write(const char *name, int index, uint64_t addr, uint64_t data,
> unsigned size) " (%s:region%d+0x%"PRIx64", 0x%"PRIx64 ", %d)"
> vfio_region_read(char *name, int index, uint64_t addr, unsigned size,
> uint64_t data) " (%s:region%d+0x%"PRIx64", %d) = 0x%"PRIx64
> -vfio_iommu_map_notify(uint64_t iova_start, uint64_t iova_end) "iommu map @
> %"PRIx64" - %"PRIx64
> +vfio_iommu_map_notify(const char *op, uint64_t iova_start, uint64_t
> iova_end) "iommu %s @ %"PRIx64" - %"PRIx64
> vfio_listener_region_add_skip(uint64_t start, uint64_t end) "SKIPPING
> region_add %"PRIx64" - %"PRIx64
> vfio_listener_region_add_iommu(uint64_t start, uint64_t end) "region_add
> [iommu] %"PRIx64" - %"PRIx64
> vfio_listener_region_add_ram(uint64_t iova_start, uint64_t iova_end, void
> *vaddr) "region_add [ram] %"PRIx64" - %"PRIx64" [%p]"
- [Qemu-devel] [PATCH RFC v4 00/20] VT-d: vfio enablement and misc enhances, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 03/20] vfio: allow to notify unmap for very large region, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 04/20] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 05/20] intel_iommu: simplify irq region translation, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 06/20] intel_iommu: renaming gpa to iova where proper, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 07/20] intel_iommu: fix trace for inv desc handling, Peter Xu, 2017/01/20