[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when contex
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate |
Date: |
Tue, 24 Jan 2017 12:52:42 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Jan 23, 2017 at 06:36:17PM +0800, Jason Wang wrote:
>
>
> On 2017年01月20日 21:08, Peter Xu wrote:
> >Before this one we only invalidate context cache when we receive context
> >entry invalidations. However it's possible that the invalidation also
> >contains a domain switch (only if cache-mode is enabled for vIOMMU). In
> >that case we need to notify all the registered components about the new
> >mapping.
> >
> >Signed-off-by: Peter Xu <address@hidden>
> >---
> > hw/i386/intel_iommu.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> >diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> >index f9c5142..4b08b4d 100644
> >--- a/hw/i386/intel_iommu.c
> >+++ b/hw/i386/intel_iommu.c
> >@@ -1146,6 +1146,16 @@ static void
> >vtd_context_device_invalidate(IntelIOMMUState *s,
> > trace_vtd_inv_desc_cc_device(bus_n, VTD_PCI_SLOT(devfn_it),
> > VTD_PCI_FUNC(devfn_it));
> > vtd_as->context_cache_entry.context_cache_gen = 0;
> >+ /*
> >+ * So a device is moving out of (or moving into) a
> >+ * domain, a replay() suites here to notify all the
> >+ * IOMMU_NOTIFIER_MAP registers about this change.
> >+ * This won't bring bad even if we have no such
> >+ * notifier registered - the IOMMU notification
> >+ * framework will skip MAP notifications if that
> >+ * happened.
> >+ */
> >+ memory_region_iommu_replay_all(&vtd_as->iommu);
>
> DSI and GLOBAL questions come back again or no need to care about them :) ?
DSI/GLOBAL hanldings are in patch 20 (though it'll be squashed into 18
in my next post). Is that what you mean above?
Thanks!
-- peterx
- [Qemu-devel] [PATCH RFC v4 09/20] intel_iommu: vtd_slpt_level_shift check level, (continued)
- [Qemu-devel] [PATCH RFC v4 09/20] intel_iommu: vtd_slpt_level_shift check level, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 10/20] memory: add section range info for IOMMU notifier, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 11/20] memory: provide IOMMU_NOTIFIER_FOREACH macro, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 12/20] memory: provide iommu_replay_all(), Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 13/20] memory: introduce memory_region_notify_one(), Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 14/20] memory: add MemoryRegionIOMMUOps.replay() callback, Peter Xu, 2017/01/20
- [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate, Peter Xu, 2017/01/20
- Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate, Jason Wang, 2017/01/23
- Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate,
Peter Xu <=
- Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate, Jason Wang, 2017/01/24
- Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate, Peter Xu, 2017/01/24
- Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate, Tian, Kevin, 2017/01/25
- Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate, Peter Xu, 2017/01/25
- Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate, Jason Wang, 2017/01/25
[Qemu-devel] [PATCH RFC v4 15/20] intel_iommu: provide its own replay() callback, Peter Xu, 2017/01/20