[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 08/14] savevm: add public save_vmstate function
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH v7 08/14] savevm: add public save_vmstate function |
Date: |
Tue, 24 Jan 2017 10:17:41 +0300 |
User-agent: |
StGit/0.16 |
This patch introduces save_vmstate function to allow saving and loading
vmstates from the replay module.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
include/sysemu/sysemu.h | 1 +
migration/savevm.c | 33 ++++++++++++++++++++++-----------
2 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index cccde56..4cdba34 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -75,6 +75,7 @@ void qemu_add_machine_init_done_notifier(Notifier *notify);
void qemu_remove_machine_init_done_notifier(Notifier *notify);
void hmp_savevm(Monitor *mon, const QDict *qdict);
+int save_vmstate(Monitor *mon, const char *name);
int load_vmstate(const char *name);
void hmp_delvm(Monitor *mon, const QDict *qdict);
void hmp_info_snapshots(Monitor *mon, const QDict *qdict);
diff --git a/migration/savevm.c b/migration/savevm.c
index f9c06e9..1e69225 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2039,38 +2039,40 @@ int qemu_loadvm_state(QEMUFile *f)
return ret;
}
-void hmp_savevm(Monitor *mon, const QDict *qdict)
+int save_vmstate(Monitor *mon, const char *name)
{
BlockDriverState *bs, *bs1;
QEMUSnapshotInfo sn1, *sn = &sn1, old_sn1, *old_sn = &old_sn1;
- int ret;
+ int ret = -1;
QEMUFile *f;
int saved_vm_running;
uint64_t vm_state_size;
qemu_timeval tv;
struct tm tm;
- const char *name = qdict_get_try_str(qdict, "name");
Error *local_err = NULL;
AioContext *aio_context;
if (!bdrv_all_can_snapshot(&bs)) {
monitor_printf(mon, "Device '%s' is writable but does not "
"support snapshots.\n", bdrv_get_device_name(bs));
- return;
+ return ret;
}
/* Delete old snapshots of the same name */
- if (name && bdrv_all_delete_snapshot(name, &bs1, &local_err) < 0) {
- error_reportf_err(local_err,
- "Error while deleting snapshot on device '%s': ",
- bdrv_get_device_name(bs1));
- return;
+ if (name) {
+ ret = bdrv_all_delete_snapshot(name, &bs1, &local_err);
+ if (ret < 0) {
+ error_reportf_err(local_err,
+ "Error while deleting snapshot on device '%s': ",
+ bdrv_get_device_name(bs1));
+ return ret;
+ }
}
bs = bdrv_all_find_vmstate_bs();
if (bs == NULL) {
monitor_printf(mon, "No block device can accept snapshots\n");
- return;
+ return ret;
}
aio_context = bdrv_get_aio_context(bs);
@@ -2079,7 +2081,7 @@ void hmp_savevm(Monitor *mon, const QDict *qdict)
ret = global_state_store();
if (ret) {
monitor_printf(mon, "Error saving global state\n");
- return;
+ return ret;
}
vm_stop(RUN_STATE_SAVE_VM);
@@ -2125,13 +2127,22 @@ void hmp_savevm(Monitor *mon, const QDict *qdict)
if (ret < 0) {
monitor_printf(mon, "Error while creating snapshot on '%s'\n",
bdrv_get_device_name(bs));
+ goto the_end;
}
+ ret = 0;
+
the_end:
aio_context_release(aio_context);
if (saved_vm_running) {
vm_start();
}
+ return ret;
+}
+
+void hmp_savevm(Monitor *mon, const QDict *qdict)
+{
+ save_vmstate(mon, qdict_get_try_str(qdict, "name"));
}
void qmp_xen_save_devices_state(const char *filename, Error **errp)
- [Qemu-devel] [PATCH v7 01/14] icount: update instruction counter on apic patching, (continued)
- [Qemu-devel] [PATCH v7 01/14] icount: update instruction counter on apic patching, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 02/14] replay: improve interrupt handling, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 03/14] replay: exception replay fix, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 04/14] icount: exit cpu loop on expire, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 05/14] apic: save apic_delivered flag, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 06/14] replay: don't use rtc clock on loadvm phase, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 08/14] savevm: add public save_vmstate function,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH v7 07/14] integratorcp: adding vmstate for save/restore, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 09/14] replay: save/load initial state, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 10/14] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 11/14] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 12/14] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 13/14] audio: make audio poll timer deterministic, Pavel Dovgalyuk, 2017/01/24
- [Qemu-devel] [PATCH v7 14/14] replay: add record/replay for audio passthrough, Pavel Dovgalyuk, 2017/01/24
- Re: [Qemu-devel] [PATCH v7 00/14] replay additions, no-reply, 2017/01/24
- Re: [Qemu-devel] [PATCH v7 00/14] replay additions, Paolo Bonzini, 2017/01/25