[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] niagara: check if a serial port is availabl
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] niagara: check if a serial port is available |
Date: |
Tue, 24 Jan 2017 09:25:01 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Your series lacks threading: the patches don't carry In-Reply-To and
References headers. The easiest way to fix that is sending them with
git-send-email --thread. You should be able to omit --thread; it's the
default unless configured otherwise.
Artyom Tarasenko <address@hidden> writes:
> Reported-by:Markus Armbruster <address@hidden>
> Signed-off-by: Artyom Tarasenko <address@hidden>
> ---
> hw/sparc64/niagara.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c
> index e945b5a..a14724f 100644
> --- a/hw/sparc64/niagara.c
> +++ b/hw/sparc64/niagara.c
> @@ -154,9 +154,10 @@ static void niagara_init(MachineState *machine)
> exit(1);
> }
> }
> - serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
> - serial_hds[0], DEVICE_BIG_ENDIAN);
> -
> + if (serial_hds[0]) {
> + serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
> + serial_hds[0], DEVICE_BIG_ENDIAN);
> + }
> empty_slot_init(NIAGARA_IOBBASE, NIAGARA_IOBSIZE);
> sun4v_rtc_init(NIAGARA_RTC_BASE);
> }
Reviewed-by: Markus Armbruster <address@hidden>