qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing
Date: Tue, 24 Jan 2017 09:55:14 +0000

On 24 January 2017 at 08:21, Markus Armbruster <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
>> PS: doesn't this break 'make check' if the rom files
>> are missing?
>
> Yes, it does.  Obvious incremental fix appended.  It still prints
> rom_add_file()'s message.  Swap the operands of && to get rid of it.

Yes, we should do this with
 (!qtest_enabled && rom_add_file_fixed(file, addr, -1))
to avoid printing the warnings in the make check output.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]