[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/8] ui: add ability to specify multiple VNC
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 8/8] ui: add ability to specify multiple VNC listen addresses |
Date: |
Tue, 24 Jan 2017 13:15:42 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/24/2017 03:53 AM, Daniel P. Berrange wrote:
> This change allows the listen address and websocket address
> options for -vnc to be repeated. This causes the VNC server
> to listen on multiple addresses. e.g.
>
> $ $QEMU -vnc vnc=localhost:1,vnc=unix:/tmp/vnc,\
> websocket=127.0.0.1:8080,websocket=[::]:8081
>
> results in listening on
>
> 127.0.0.1:5901, 127.0.0.1:8080, ::1:5901, :::8081 & /tmp/vnc
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> ui/vnc.c | 198
> +++++++++++++++++++++++++++++++++++++++++++--------------------
> 1 file changed, 135 insertions(+), 63 deletions(-)
>
> @@ -3835,7 +3901,9 @@ void vnc_display_open(const char *id, Error **errp)
> return;
> }
>
> - if (vnc_display_get_addresses(opts, &saddr, &wsaddr, errp) < 0) {
> + if (vnc_display_get_addresses(opts, &saddr, &nsaddr,
> + &wsaddr, &nwsaddr, errp) < 0) {
> + g_printerr("failing\n");
> goto fail;
Leftover debugging?
Otherwise looks okay, so with that line gone,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/8] Support multiple listening sockets per VNC server, Daniel P. Berrange, 2017/01/24
- [Qemu-devel] [PATCH v2 1/8] ui: fix regression handling bare 'websocket' option to -vnc, Daniel P. Berrange, 2017/01/24
- [Qemu-devel] [PATCH v2 2/8] ui: fix reporting of VNC auth in query-vnc-servers, Daniel P. Berrange, 2017/01/24
- [Qemu-devel] [PATCH v2 3/8] ui: refactor VncDisplay to allow multiple listening sockets, Daniel P. Berrange, 2017/01/24
- [Qemu-devel] [PATCH v2 6/8] ui: let VNC server listen on all resolved IP addresses, Daniel P. Berrange, 2017/01/24
- [Qemu-devel] [PATCH v2 4/8] ui: refactor code for populating SocketAddress from vnc_display_open, Daniel P. Berrange, 2017/01/24
- [Qemu-devel] [PATCH v2 5/8] ui: extract code to connect/listen from vnc_display_open, Daniel P. Berrange, 2017/01/24
- [Qemu-devel] [PATCH v2 7/8] util: add iterators for QemuOpts values, Daniel P. Berrange, 2017/01/24
- [Qemu-devel] [PATCH v2 8/8] ui: add ability to specify multiple VNC listen addresses, Daniel P. Berrange, 2017/01/24
- Re: [Qemu-devel] [PATCH v2 8/8] ui: add ability to specify multiple VNC listen addresses,
Eric Blake <=